Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(server): Rename components dealing with envelopes #984

Merged
merged 8 commits into from
Apr 23, 2021

Conversation

jan-auer
Copy link
Member

This cleans up long-standing legacy from when Relay only supported events but no envelopes. Most importantly, the actors for queueing and processing envelopes are now called EnvelopeManager and EnvelopeProcessor. Additionally:

  • Renames the module declaring the envelope actors to actors::envelopes
  • Renames error variants used for envelopes, and updates their Display impl
  • Renames the global counter for in-flight envelopes to active_envelopes
  • Renames accessor methods on relay_config::Config for the envelope buffer size
  • Updates comments and logs around envelope processing in the envelopes module

#skip-changelog

@jan-auer jan-auer requested a review from a team April 23, 2021 10:13
@jan-auer jan-auer self-assigned this Apr 23, 2021
@jan-auer
Copy link
Member Author

I recommend reviewers to look at each commit separately.

@jan-auer jan-auer force-pushed the ref/rename-events-actors branch from 2fab5f3 to 3ad68c3 Compare April 23, 2021 10:18
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems straightforward, this will create some new groups in s4s but nothing else

@jan-auer jan-auer enabled auto-merge (squash) April 23, 2021 11:09
@jan-auer jan-auer merged commit 3933cd6 into master Apr 23, 2021
@jan-auer jan-auer deleted the ref/rename-events-actors branch April 23, 2021 11:14
jan-auer added a commit that referenced this pull request Apr 23, 2021
* master:
  ref(server): Rename components dealing with envelopes (#984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants