feat(pii): Make $error.value pii=true #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is not really a good reason as to why one would have to jump through a bunch of hoops to scrub this field. It is mostly equivalent to `$message` in what it contains (to the point people confuse one with another) and impacts grouping in similar ways. The kickoff for this PR was when a customer attempted to configure `$error.**` and failed. The original concern with making this pii=true was that it would impact grouping, but if anything, removing PII/variable data improves grouping. This is more of a concern with the Default Scrubbers where the entire value may be removed, which is why the field has been put on the ignore-list for those.
jan-auer
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not really a good reason as to why one would have to jump
through a bunch of hoops to scrub this field. It is mostly equivalent to
$messagein what it contains (to the point people confuse one withanother) and impacts grouping in similar ways. So it should be scrubbable
the same way.
The kickoff for this PR was when a customer attempted to configure
$error.**and failed.The original concern with making this pii=true was that it would impact
grouping, but if anything, removing PII/variable data improves grouping.
This is more of a concern with the Default Scrubbers where the entire
value may be removed, which is why the field has been put on the
ignore-list for those.