Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Send envelopes to the envelope endpoint #746

Merged
merged 3 commits into from
Sep 2, 2020
Merged

fix(server): Send envelopes to the envelope endpoint #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d67515b
fix(server): Send envelopes to the envelope endpoint
jan-auer Sep 2, 2020
b385171
meta: Changelog
jan-auer Sep 2, 2020
170baba
fix: Typo in changelog
jan-auer Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
- Add periodic re-authentication with the upstream server, previously there was only one initial authentication. ([#731](https://github.com/getsentry/relay/pull/731))
- The module attribute on stack frames (`$frame.module`) and the (usually serverside-generated) attribute `culprit` can now be scrubbed with advanced data scrubbing. ([#744](https://github.com/getsentry/relay/pull/744))

**Bug Fixes**:

- Send requests to the `/envelope/` endpoint instead of the older `/store/` endpoint. This particularly fixes spurious `413 Payload Too Large` errors returned when using Relay with Sentry SaaS. ([#746](https://github.com/getsentry/relay/pull/746))

**Internal**:

- Remove a temporary flag from attachment kafka messages indicating rate limited crash reports to Sentry. This is now enabled by default. ([#718](https://github.com/getsentry/relay/pull/718))
Expand All @@ -30,7 +34,6 @@
- Fix hashing of user IP addresses in data scrubbing. Previously, this could create invalid IP addresses which were later rejected by Sentry. Now, the hashed IP address is moved to the `id` field. ([#692](https://github.com/getsentry/relay/pull/692))
- Do not retry authentication with the upstream when a client error is reported (status code 4XX). ([#696](https://github.com/getsentry/relay/pull/696))


**Internal**:

- Extract the event `timestamp` from Minidump files during event normalization. ([#662](https://github.com/getsentry/relay/pull/662))
Expand Down
2 changes: 1 addition & 1 deletion relay-server/src/actors/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,7 +1432,7 @@ impl Handler<HandleEnvelope> for EventManager {
}

log::trace!("sending event to sentry endpoint");
let request = SendRequest::post(format!("/api/{}/store/", project_id)).build(
let request = SendRequest::post(format!("/api/{}/envelope/", project_id)).build(
move |builder| {
// Override the `sent_at` timestamp. Since the event went through basic
// normalization, all timestamps have been corrected. We propagate the new
Expand Down
3 changes: 2 additions & 1 deletion tests/integration/fixtures/mini_sentry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def store_internal_error_event():
)
return jsonify({"event_id": uuid.uuid4().hex})

@app.route("/api/42/store/", methods=["POST"])
@app.route("/api/42/envelope/", methods=["POST"])
def store_event():
if flask_request.headers.get("Content-Encoding", "") == "gzip":
data = gzip.decompress(flask_request.data)
Expand All @@ -144,6 +144,7 @@ def store_event():
return jsonify({"event_id": uuid.uuid4().hex})

@app.route("/api/<project>/store/", methods=["POST"])
@app.route("/api/<project>/envelope/", methods=["POST"])
def store_event_catchall(project):
raise AssertionError(f"Unknown project: {project}")

Expand Down