Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing .NET 4.8 patches #642

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jun 29, 2020

Adds support on the server to display the correct version. Related to: getsentry/sentry-dotnet#443 even though it doesn't solve it since Sentry.PlatformAbstractions can also be patched before resolving.

@bruno-garcia bruno-garcia requested a review from a team June 29, 2020 23:58
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia is there a way we could get this information from somewhere else? If there were some config file we can pull in regular intervals, I could generate this list from the file.

@bruno-garcia
Copy link
Member Author

Sadly there isn't. And the docs.microsoft I took the original value isn't updated with this one.
4.8 is the latest release (.NET Core is the future) so there shouldn't be many newer ones (famous last words).

@bruno-garcia bruno-garcia merged commit 1231dd9 into master Jun 30, 2020
@bruno-garcia bruno-garcia deleted the fix/dotnet-4.8-patches branch June 30, 2020 14:45
jan-auer added a commit that referenced this pull request Jul 2, 2020
* master:
  fix(server): Do not 429 for event-only attachments (#647)
  doc(config): Remove references to advanced data scrubbing (#648)
  fix(server): Never respond with 429 for minidumps (#646)
  docs(config): Update relay end user documentation (#641)
  license: Update BSL change date
  fix: Add missing .NET 4.8 patches (#642)
  feat(server): Emit attachment sizes to Kafka (#644)
  fix(store): Use clock drift normalizer to correct all timestamp issues  (#634)
  feat(server): Emit flags for rate limited attachments (#640)
  feat(server): Enforce attachment size in rate limits (#639)
  feat(server): Apply quotas per item (#636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants