-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pool): Use new AsyncPool
for the processor and store services
#4520
feat(pool): Use new AsyncPool
for the processor and store services
#4520
Conversation
AsyncPool
for the processor and store services
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
8408e01
to
d2b7601
Compare
relay-threading/src/multiplexing.rs
Outdated
// We report how many tasks are being concurrently polled in this future. | ||
relay_statsd::metric!( | ||
gauge(AsyncPoolGauges::AsyncPoolFuturesPerThread) = this.tasks.len() as u64, | ||
pool_name = &this.pool_name, | ||
thread_name = &this.thread_name | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably too high cardinality, maybe we just emit the total size somewhere or the max?
Also we don't have to do it on each poll only when the futures length changes (e.g. on push)
This PR integrates the new
AsyncPool
in theEnvelopeProcessorService
andStoreService
.Please note that currently the integration doesn't leverage the benefits of async, since all the functions called by the pool are blocking. The support for async in the I/O operations of the
EnvelopeProcessorService
will be coming.Closes: https://github.com/getsentry/team-ingest/issues/645