feat(redis): Implement parallel cmd execution of Redis calls #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
requested changes
Oct 8, 2024
Dav1dde
reviewed
Oct 8, 2024
iambriccardo
force-pushed
the
riccardo/feat/parallel-redis
branch
from
3dda741 to
22f294e
Compare
jjbayer
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
As discussed, we can merge this as an experiment, but we should keep a close eye on number of threads created vs OS thread limits wherever we deploy this. If spawning a thread for every call is not feasible, we'll have to move to a thread pool.
Joining on the secondaries should be fine as long as we assume them to be at least as fast as the primary.
Dav1dde
reviewed
Oct 8, 2024
Dav1dde
approved these changes
Oct 8, 2024
Dav1dde
reviewed
Oct 9, 2024
jan-auer
added a commit
that referenced
this pull request
Oct 21, 2024
* master: ref(server): Move project source into the source module (#4154) instr(buffer): Measure envelope size (#4153) ref(redis): Cleanup code around Redis (#4151) lint: Rust 1.82 (#4150) chore(server): Remove native placeholders from transaction processing (#4148) feat(eap): Extract user IP (#4144) Revert "ref(buffer): remove peek" (#4146) ref(buffer): remove peek (#4136) release: 24.10.0 build(deps): bump tonic from 0.12.2 to 0.12.3 (#4143) instr(projects): Log fetch failure (#4142) ref(otel): Disable default features for otel schema (#4141) ref(server): Organize project services in nested modules (#4139) ref(redis): Update to redis client version 0.27.4 (#4132) feat(redis): Implement parallel cmd execution of Redis calls (#4118) feat(spooler): Add metric to track serialization performance (#4135)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the parallelization of Redis calls via scoped threads. The goal is to avoid blocking calls when dealing with the
MultiWriteRedis client.Closes: #4100