fix(replays): Run TrimmingProcessor on replays #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Jun 7, 2024
bruno-garcia
reviewed
Jun 7, 2024
| #[test] | ||
| fn test_maxchars_trimming() { | ||
| let json = format!(r#"{{"dist": "{}"}}"#, "0".repeat(100)); | ||
| let mut replay = Annotated::<Replay>::from_json(json.as_str()).unwrap(); |
There was a problem hiding this comment.
test only stresses dist, should it test the other fields too?
cmanallen
approved these changes
Jun 7, 2024
Yep, that's correct.
Yes, let me know if I should clarify further the PR description.
The test validates that the trimming processor runs on replays, and there are separate tests to validate that the trimming processor trims fields with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although some fields in replays have
max_charsdefined, the trimming processor isn't run and thus the limit is not enforced. This PR runs the processor and enforces that limit.