Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric-stats): Only emit volume metadata for the first bucket view #3609

Merged
merged 2 commits into from
May 16, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented May 16, 2024

Splitting a bucket into multiple via a BucketView brings the problem that some of the metadata can't be attributed correctly anymore (aggregation is a lossy process for metadata). To solve this problem for the volume metadata, it will only be attached to the bucket view containing the start of the bucket.

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner May 16, 2024 07:42
@Dav1dde Dav1dde self-assigned this May 16, 2024
@Dav1dde Dav1dde merged commit 64ea4e9 into dav1d/metric-outcomes May 16, 2024
21 checks passed
@Dav1dde Dav1dde deleted the dav1d/bucket-meta-volume branch May 16, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants