Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(metric-stats): Rate limit before cardinality limiting #3582

Merged
merged 2 commits into from
May 13, 2024
Merged

ref(metric-stats): Rate limit before cardinality limiting #3582

merged 2 commits into from
May 13, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented May 13, 2024

For enforced quotas we do not want to track cardinality.

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner May 13, 2024 05:21
@Dav1dde Dav1dde self-assigned this May 13, 2024
@Dav1dde Dav1dde mentioned this pull request May 13, 2024
Closed
iambriccardo
iambriccardo approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dav1dde Dav1dde enabled auto-merge (squash) May 13, 2024 13:59
@Dav1dde Dav1dde merged commit a0b1eef into master May 13, 2024
22 checks passed
@Dav1dde Dav1dde deleted the dav1d/rate-before-card branch May 13, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iambriccardo iambriccardo iambriccardo approved these changes

Assignees

@Dav1dde Dav1dde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dav1dde @iambriccardo