feat(metric-stats): Add additional tags to metric stats metrics #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Apr 16, 2024
Comment on lines
-166
to
-168
| if !namespace.has_metric_stats() { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
Yes and no, we can now track cardinality limits which are not associated with a metric (Type). The on/off is now only controlled through report: True on the cardinality limit, which I think does make sense.
I'll kill the has_metric_stats in a follow-up, Jan didn't seem to like it anyways, currently it's still needed for the volume metric 👍 .
Dav1dde
force-pushed
the
dav1d/card-report-id-scope
branch
from
9ce478b to
044595b
Compare
Dav1dde
force-pushed
the
dav1d/card-report-id-scope
branch
from
044595b to
6134468
Compare
Closed
jjbayer
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports additional tags with the metric stats metrics.
#skip-changelog