Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric-stats): Implement per type cardinality limits #3437

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Apr 16, 2024

Implements by metric type cardinality limits, these limits don't necessarily make sense to be enforced, but can be used for cardinality reports if you want to weigh cardinality for each type differently.

#skip-changelog

@Dav1dde Dav1dde requested a review from a team as a code owner April 16, 2024 09:54
@Dav1dde Dav1dde self-assigned this Apr 16, 2024
@Dav1dde Dav1dde mentioned this pull request Apr 16, 2024
@Dav1dde Dav1dde force-pushed the dav1d/card-by-type branch from c7f578a to e918491 Compare April 16, 2024 10:10
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still two open comments, but nothing blocking.

@Dav1dde Dav1dde merged commit 9511e14 into master Apr 16, 2024
20 checks passed
@Dav1dde Dav1dde deleted the dav1d/card-by-type branch April 16, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants