Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(cardinality): Switch histogram to gauge #3331

Merged
merged 1 commit into from
Mar 26, 2024
Merged

ref(cardinality): Switch histogram to gauge #3331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions relay-cardinality/src/redis/limiter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::{
script::{CardinalityScript, Status},
state::{LimitState, RedisEntry},
},
statsd::{CardinalityLimiterHistograms, CardinalityLimiterTimers},
statsd::{CardinalityLimiterGauges, CardinalityLimiterTimers},
CardinalityLimit, Result,
};
use relay_common::time::UnixTimestamp;
Expand Down Expand Up @@ -63,7 +63,7 @@ impl RedisSetLimiter {
let entries = state.take_entries();

metric!(
histogram(CardinalityLimiterHistograms::RedisCheckHashes) = entries.len() as u64,
gauge(CardinalityLimiterGauges::RedisCheckHashes) = entries.len() as u64,
id = state.id(),
);

Expand All @@ -79,7 +79,7 @@ impl RedisSetLimiter {
.invoke(con, limit, scope.redis_key_ttl(), hashes, keys)?;

metric!(
histogram(CardinalityLimiterHistograms::RedisSetCardinality) = result.cardinality,
gauge(CardinalityLimiterGauges::RedisSetCardinality) = result.cardinality,
id = state.id(),
);

Expand Down
6 changes: 3 additions & 3 deletions relay-cardinality/src/statsd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use relay_statsd::{CounterMetric, HistogramMetric, SetMetric, TimerMetric};
use relay_statsd::{CounterMetric, GaugeMetric, SetMetric, TimerMetric};

/// Counter metrics for the Relay Cardinality Limiter.
pub enum CardinalityLimiterCounters {
Expand Down Expand Up @@ -81,7 +81,7 @@ impl TimerMetric for CardinalityLimiterTimers {
}
}

pub enum CardinalityLimiterHistograms {
pub enum CardinalityLimiterGauges {
/// Amount of hashes sent to Redis to check the cardinality.
///
/// This metric is tagged with:
Expand All @@ -96,7 +96,7 @@ pub enum CardinalityLimiterHistograms {
RedisSetCardinality,
}

impl HistogramMetric for CardinalityLimiterHistograms {
impl GaugeMetric for CardinalityLimiterGauges {
fn name(&self) -> &'static str {
match *self {
#[cfg(feature = "redis")]
Expand Down
Loading