-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Add metadata for buckets #3254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jjbayer
reviewed
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm unsure about the .await
in from_request_parts
.
What happens when a bucket goes into the pre-aggregator because a project state has not been loaded? Will the accounting be correct?
jjbayer
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
BucketMetadata
to the metricsBucket
. The metadata can be used to track meta information about the bucket, like amount of aggregations (total merges).The metadata currently only tracks the amount of "merges".
Bucket metadata is a purely Relay internal detail, clients are not expected to send it and Relay will ignore and reset the metadata if it is not coming from a trusted/internal Relay. This makes it possible to to implement the received timestamp for metrics while at the same time forwarding the metadata correctly from PoPs to Processing Relays without any additional configurations.
This PR contains:
The metadata is currently unused, I will add all missing integration tests once it is possible to properly assert the metadata in an integration test. I have manually verified that the aggregation of metadata is working.
Change is smaller than it looks, most of it is just test snapshots.