Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instr(kafka): Tag producer error metric with topic #3189

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Mar 1, 2024

There is an alert based on this metric. Tagging it by topic will make the problem faster to diagnose (no need to go and check the accompanying sentry issue).

#skip-changelog

@jjbayer jjbayer marked this pull request as ready for review March 1, 2024 08:11
@jjbayer jjbayer requested review from bmckerry and a team March 1, 2024 08:11
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@jjbayer jjbayer merged commit 18a197e into master Mar 1, 2024
21 checks passed
@jjbayer jjbayer deleted the instr/kafka-topic branch March 1, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants