Extend GPU context with data for Unreal Engine crash reports #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slonopotamus
force-pushed
the
extend-unreal-gpu-context
branch
3 times, most recently
from
c52fdc5 to
76653be
Compare
Dav1dde
reviewed
Feb 20, 2024
|
Updated PR to include a changelog entry |
slonopotamus
force-pushed
the
extend-unreal-gpu-context
branch
3 times, most recently
from
b4af5c3 to
eddd7c8
Compare
Dav1dde
reviewed
Feb 20, 2024
slonopotamus
force-pushed
the
extend-unreal-gpu-context
branch
2 times, most recently
from
73fa50a to
3f6bf2b
Compare
Dav1dde
approved these changes
Feb 20, 2024
|
Thanks for the contribution, changes should go out to SaaS today or latest tomorrow, the next Relay release will be next month! |
1. This commit replaces primary GPU with the one that is actually used for rendering. These two may be different for laptops. Fixes getsentry/sentry#27498 2. This commit adds other available data: * Numeric DeviceID * Used feature level (SM5, SM6, etc) * GPU vendor name * GPU driver version * RHI type that is used (Metal, Vulkan, DX11, etc) Signed-off-by: Marat Radchenko <[email protected]>
auto-merge was automatically disabled
February 20, 2024 09:19
Head branch was pushed to by a user without write access
slonopotamus
force-pushed
the
extend-unreal-gpu-context
branch
from
3f6bf2b to
174dbdc
Compare
|
Fixed tests. |
|
That was fast, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.