Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Revert changes to HttpServer startup #313

Merged
merged 2 commits into from
Nov 13, 2019

Conversation

untitaker
Copy link
Member

Those two changes did not improve performance so let's revert them.

@untitaker untitaker requested a review from jan-auer November 13, 2019 10:50
@jan-auer jan-auer changed the title ref: Revert unnecessary changes ref: Revert changes to HttpServer startup Nov 13, 2019
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@untitaker untitaker merged commit 05963aa into master Nov 13, 2019
@untitaker untitaker deleted the ref/revert-unnecessary-changes branch November 13, 2019 11:15
jan-auer added a commit that referenced this pull request Nov 13, 2019
* master:
  ref: Revert changes to HttpServer startup (#313)
  meta: Changelog for 0.4.61
  feat(general): Add thread.errored attribute (#306)
  release: 0.4.60
  doc: Changelog for 0.4.60
  fix: Start clientconnector earlier
  fix: Spawn http server on separate thread (#312)
  feat: More concurrency options (#311)
  fix: Formatting
  fix: Ignore venv of load tests
  feat(load-tests): Added semaphore-load-test project back into semaphore (#309)
jan-auer added a commit that referenced this pull request Nov 13, 2019
* feat/envelopes: (110 commits)
  ref: Revert changes to HttpServer startup (#313)
  meta: Changelog for 0.4.61
  feat(general): Add thread.errored attribute (#306)
  fix(config): Add a default for the attachment chunk size
  feat(server): Add back missing release and env for security reports
  feat: Re-introduce security report normalization
  feat(server): Implement sending of attachments to Kafka
  release: 0.4.60
  doc: Changelog for 0.4.60
  ref(server): Use envelopes to encapsulate EventMeta
  fix: Start clientconnector earlier
  fix: Spawn http server on separate thread (#312)
  ref(server): Unify incoming and outgoing envelopes
  fix(clippy): Implement Default for EventId
  fix(server): Add serialization for incoming envelopes
  ref(server): Move python shim logic to store endpoint
  feat(general): Create a constructor for EventId
  wip: Restructure EventProcessor to work on envelopes
  feat: More concurrency options (#311)
  fix: Formatting
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants