fix: Normalize route path in trace context data #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @cleptric |
iker-barriocanal
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Thanks for the fix!
I wonder if we should document this in the trace context to avoid similar issues in the future.
| } | ||
| Annotated(None, meta) => Annotated(None, meta), | ||
| Annotated(Some(value), mut meta) => { | ||
| meta.add_error(Error::expected("route")); |
There was a problem hiding this comment.
nit (not sure if the message is the most helpful one):
Suggested change
| meta.add_error(Error::expected("route")); | |
| meta.add_error(Error::expected("route expected to be an object")); |
added docs getsentry/develop#1157 |
iker-barriocanal
approved these changes
Feb 14, 2024
Dav1dde
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay expects for
contexts.trace.data.routeto be a route, but some SDKs sent the string (for route names) inrouteand we want to handle this and normalize the data into the know types structure.This PR introduces the customer
FromValuetrait implementation forRouteto handle:contexts.trace.data.routefieldfix: #3000