feat(metrics-summaries): Emit summaries to their own topic #3045
Conversation
relay-server/src/services/store.rs
Outdated
| KafkaTopic::MetricsSummaries, | ||
| scoping.organization_id, | ||
| KafkaMessage::MetricsSummary(MetricsSummaryKafkaMessage { | ||
| count: summary.count.unwrap_or_default(), |
There was a problem hiding this comment.
I assume that the fields of MetricsSummary are Optional for a reason. IMO we should do one of two things:
- Make the fields of
MetricsSummarynon-optional. - If it actually makes sense that these fields are empty, make the consumer accept missing /
nullvalues.
There was a problem hiding this comment.
I think I forgot where I was going with this. The consumer supports missing values but not null values and I think I wanted to turn that into non-optional values.
| /// Summary for metrics collected during a span. | ||
| pub metrics_summaries: TopicAssignment, |
There was a problem hiding this comment.
Let's make sure we have the topic created and relay configuration in place before merging this, to not risk auto-creating the topic on the default cluster.
There was a problem hiding this comment.
The topic was already created by @mwarkentin on the spans cluster but I should probably add some config to Relay in order to not auto-create it on the events cluster.
There was a problem hiding this comment.
|
Created a schema for this topic: getsentry/sentry-kafka-schemas#212. |
Instead of pushing metrics summaries as part of spans and having the Snuba consumer reads all spans, we're going to emit metrics summaries to their own topic.