ref(normalization): Reduce processor module visibility #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This module now contains very little functionality. I'm going to keep it for now, as more things will be moving around and I don't want to set a clear definition of modules until functional refactors are finished. Let me know if you have a strong opinion that differs from this.
There was a problem hiding this comment.
I would still rename this module in this PR, just to reflect it does not contain processor anymore.
There was a problem hiding this comment.
Yeah that's fair. Addressed in c31fea2.
olksdr
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
I would still rename this module in this PR, just to reflect it does not contain processor anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2714 (comment).
The are a lot of tests requiring
NormalizeProcessorintransactions/processor.rs, forcing higher visibility than necessary onnormalize/processor.rs. This PR moves required tests from one module to another, thus reducing the required module visibility. As we continue to refactor the processors, we'll find a better home for functions and tests.This PR does not contain any functional changes or updates to tests.
#skip-changelog