Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic-config): Expose metric extraction to all Relays #2440

Merged
merged 3 commits into from
Aug 30, 2023
Merged

fix(dynamic-config): Expose metric extraction to all Relays #2440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69ed63c
fix(dynamic-config): Expose metric extraction to all Relays
jan-auer Aug 30, 2023
4dc3e9c
Merge branch 'master' into fix/external-relays-on-demand-metrics
jan-auer Aug 30, 2023
a037ff2
meta: Changelog
jan-auer Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Filter out exceptions originating in Safari extensions. ([#2408](https://github.com/getsentry/relay/pull/2408))
- Fixes the `TraceContext.status` not being defaulted to `unknown` before the new metrics extraction pipeline. ([#2436](https://github.com/getsentry/relay/pull/2436))
- Support on-demand metrics for alerts and widgets in external Relays. ([#2440](https://github.com/getsentry/relay/pull/2440))

## 23.8.0

Expand Down
2 changes: 2 additions & 0 deletions relay-dynamic-config/src/project.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ pub struct LimitedProjectConfig {
pub session_metrics: SessionMetricsConfig,
#[serde(skip_serializing_if = "Option::is_none")]
pub transaction_metrics: Option<ErrorBoundary<TransactionMetricsConfig>>,
#[serde(default, skip_serializing_if = "skip_metrics_extraction")]
pub metric_extraction: ErrorBoundary<MetricExtractionConfig>,
#[serde(skip_serializing_if = "Vec::is_empty")]
pub metric_conditional_tagging: Vec<TaggingRule>,
#[serde(skip_serializing_if = "BTreeSet::is_empty")]
Expand Down
3 changes: 2 additions & 1 deletion tests/integration/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,7 +1231,8 @@ def test_generic_metric_extraction(mini_sentry, relay):
transaction["timestamp"] = timestamp.isoformat()
transaction["start_timestamp"] = (timestamp - timedelta(seconds=2)).isoformat()

relay = relay(mini_sentry, options=TEST_CONFIG)
# Explicitly test a chain of Relays
relay = relay(relay(mini_sentry, options=TEST_CONFIG), options=TEST_CONFIG)
relay.send_transaction(PROJECT_ID, transaction)

envelope = mini_sentry.captured_events.get(timeout=3)
Expand Down