Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): Consider quotes to extract the domain #2167

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

iker-barriocanal
Copy link
Contributor

Consider "s in an SQL query to extract the domain, aka table name.

#skip-changelog

@iker-barriocanal iker-barriocanal requested a review from a team May 31, 2023 14:39
@iker-barriocanal iker-barriocanal self-assigned this May 31, 2023
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one question, otherwise lgtm

@iker-barriocanal iker-barriocanal merged commit 44a2275 into master Jun 1, 2023
@iker-barriocanal iker-barriocanal deleted the iker/fix/span-domain-quotes branch June 1, 2023 15:51
romtsn pushed a commit that referenced this pull request Jun 1, 2023
Consider `"`s in an SQL query to extract the domain, aka table name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants