Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(profiling): Fix regression on making release optional and copy dist from transaction #2107

Merged
merged 4 commits into from
May 10, 2023
Merged

feat(profiling): Fix regression on making release optional and copy dist from transaction #2107

merged 4 commits into from
May 10, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented May 10, 2023

This PR aims to fix the regression introduced right after we started making the release field option.

At the same time, dist should also be copied from the transaction and should also be optional.

@phacops phacops requested a review from a team as a code owner May 10, 2023 09:55
@phacops phacops requested a review from a team May 10, 2023 09:57
jjbayer
jjbayer approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change by itself looks good to me, but what was the actual regression?

@phacops
Copy link
Contributor Author

phacops commented May 10, 2023

The change by itself looks good to me, but what was the actual regression?

I made the release optional here 018ef16. Two commits later, I reverted because of a bad merge 2555741.

@phacops phacops merged commit fcbd996 into master May 10, 2023
@phacops phacops deleted the pierre/profiling-release-and-dist branch May 10, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phacops @jjbayer @Zylphrex