Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metrics): Remove satisfaction thresholds #1881

Merged
merged 1 commit into from
Feb 24, 2023
Merged

chore(metrics): Remove satisfaction thresholds #1881

merged 1 commit into from
Feb 24, 2023

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Feb 24, 2023 •
edited
Loading

As of getsentry/sentry#33722, we do not send the satisfactionThresholds project config key anymore. See diff that removes the config here.

Satisfaction thresholds are now applied using the more generic conditional tagging mechanism.

This PR removes all traces of the old configuration and business logic.

#skip-changelog

@jjbayer jjbayer requested a review from a team February 24, 2023 12:05
olksdr
olksdr approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jjbayer jjbayer merged commit b322fd0 into master Feb 24, 2023
@jjbayer jjbayer deleted the chore/metrics-remove-satisfaction branch February 24, 2023 13:51
jan-auer added a commit that referenced this pull request Feb 24, 2023
@jan-auer
Merge branch 'master' into ref/startup
e4cf392 
* master:
  build: Upgrade sentry SDK to 0.30.0 (#1883)
  chore(metrics): Remove satisfaction thresholds (#1881)
  feat(profiling): Add javascript platform (#1876)
  fix(replays): Enforce rate limits (#1877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

@olksdr olksdr olksdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjbayer @jan-auer @olksdr