fix(test): Find librdkafka on Apple M1 #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Mar 7, 2022
armenzg
reviewed
Mar 7, 2022
| if [ "$$(uname -sm)" = "Darwin arm64" ]; then \ | ||
| echo "Using 'librdkafka' from homebrew to build confluent-kafka"; \ | ||
| export C_INCLUDE_PATH="$$(brew --prefix librdkafka)/include"; \ | ||
| export LIBRARY_PATH="$$(brew --prefix librdkafka)/lib"; \ |
There was a problem hiding this comment.
In my original PR I only needed CPATH.
It seems you used this solution:
confluentinc/confluent-kafka-python#1190 (comment)
Did you happen to find out why CPATH was not good enough? (Just out of curiosity; no need to research it if it's unknown)
armenzg
reviewed
Mar 7, 2022
| if [ "$$(uname -sm)" = "Darwin arm64" ]; then \ | ||
| echo "Using 'librdkafka' from homebrew to build confluent-kafka"; \ | ||
| export C_INCLUDE_PATH="$$(brew --prefix librdkafka)/include"; \ | ||
| export LIBRARY_PATH="$$(brew --prefix librdkafka)/lib"; \ |
There was a problem hiding this comment.
In my original PR I only needed CPATH.
It seems you used this solution:
confluentinc/confluent-kafka-python#1190 (comment)
Did you happen to find out why CPATH was not good enough? (Just out of curiosity; no need to research it if it's unknown)
There was a problem hiding this comment.
I never tried without, and you're right, it works with just the include path. Simplified in #1206.
jan-auer
added a commit
that referenced
this pull request
Mar 9, 2022
* master: ref(make): Simplify M1 exports in Makefile (#1206) fix(metrics): Wait for project states during aggregator shutdown (#1205) fix(test): Find librdkafka on Apple M1 (#1204) build: Bump sentry-relay in dev dependencies to 0.8.9 (#1202) ref(metrics): Tag backdated bucket creations in statsd (#1200) feat(metrics): Extract user satisfaction as tag (#1197) fix(statsd): Add new metric_type tag to existing metrics (#1199) fix: Apply clippy 1.59 suggestions (#1198)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
brew --prefixto locatelibrdkafkaon macOS ARM builds. The homebrewlocation differs on ARM and puts libraries in a non-standard location. There is
a similar workaround in the sentry development environment, except that it
writes exports to the zshrc / bashrc files.
See confluentinc/confluent-kafka-python#1190
As part of this change, I've also updated the README to list
librdkafkaasdevelopment dependency and upgrade
pipandwheelduring the venv setupprocess.
#skip-changelog