-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default
builtin group being associated twice with imported users
#98
Conversation
Also: - Add a progress bar to the operation - Add setting to `meta.json` to easily retrieve `destination_admin_user_id` - Make `destination_admin_user_id` of `int` type in `meta.json` - Minor polishings
Co-authored-by: Restyled.io <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. Since we don't have progress meters for any other operations, I would rather not introduce the complexity here. It might lead users to believe that the other commands are somehow broken.
Can we split this into a separate PR and implement it for all the commands?
The only reason I made the progress bar is because there's not API to delete members in batch for any given group. So I had to use the I didn't want to show an operation for each row like it happens for every other command, because it didn't make sense in this case, but on the other hand, if one has many members (for example, my instance has 83) it can take a while, thus I added the progress bar to show the user that the script is not stuck and it's doing its job. If you want to add it for every command, what should we do with the current |
@susodapop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You convinced me 👍
Tested this against the latest redash V10 image (10.0.0 (9c928bd1)
) and all works.
Fixes #96.
Also adds a progress bar to the operation and some minor polishing.