Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the Python detection. #120

Closed
wants to merge 1 commit into from
Closed

Conversation

m4rcu5
Copy link
Contributor

@m4rcu5 m4rcu5 commented Jun 28, 2017

On Gentoo (and the Arch Linux machine I had access to), the following condition is never met.

        if(out[0] > 0):
            self.check_sym_link()

This refactor will check the version, and if it does not match 2.x it will try a python2 symlink, if this still does not work, errors out with the download dialog.
Also stores the symlink name in the configuration.

Would someone be able to test the OSX implementation and the if(not external_bins): statement?

For me this fixed my issue reported at #117

@m4rcu5
Copy link
Contributor Author

m4rcu5 commented Jun 28, 2017

Though this will not fix all my issues;
the boards.json file contains:

Unknown option: -f
usage: /home/mvandam/.config/sublime-text-3/Packages/User/Deviot/penv/bin/python [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.

@gepd
Copy link
Owner

gepd commented Jun 29, 2017

To fix the boards.json, delete it and restart sublime, it should re-generate that file with right data.

Let me know if after it's fixed

@gepd
Copy link
Owner

gepd commented Jun 29, 2017

I have pushed some fixes and improvements related to the issue you have reported, my fix was simplier: 64ae87e I've added new options and improvements. (see #117)

I've test this in Ubuntu and Arch Linux but not in OSX, I'll try to do it soon

Thanks for your help!

@m4rcu5
Copy link
Contributor Author

m4rcu5 commented Jun 29, 2017

Hi @gepd, the issues as reported in #117 are fixed (will confirm there was well). I am not following along on the check_symlink(), as I would expect all moderm OS's to symlink Python in any case. This morning i was thinking of even expanding it and try all the possible options (in PATH, python, python2, python27).

But if it works, it works 😃

@gepd
Copy link
Owner

gepd commented Jun 29, 2017

Yes, I think it could be improved, until now anyone has reported a setup in python27, but will let in my task list to do, possibly to the next release

@gepd gepd closed this Jun 29, 2017
@m4rcu5 m4rcu5 deleted the deviot_2 branch June 29, 2017 07:10
@m4rcu5 m4rcu5 restored the deviot_2 branch June 29, 2017 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants