Network / Intranet configuration / Add support for multiple ip ranges #6894
Conversation
X-Forwarded-for header takes priority (in all places - Jeeves and Spring API). This fix issue while checking if client is on Intranet. By default the header is automatically set by proxy eg. Apache mod_proxy.
fxprunayre
changed the title
| if (!hasNetworkConfig | ||
| && g.getId() == ReservedGroup.intranet.getId()) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I'm not sure about this change. With this change if you configure later the intranet setting, it seems you'll have to update the privileges of the metadata.
What is the reason of this change? Was it causing some issue the original code?
There was a problem hiding this comment.
Lot of users are asking what is the Intranet group. Most of the time it is not used. So if you don't set the settings for intranet, this does not display the group in the sharing panel.
And if you at some point add intranet settings, then you'll have to change existing records privileges if you want to customize privileges for the intranet group.
There was a problem hiding this comment.
As long as that is clearly documented, sounds fine.
There was a problem hiding this comment.
Doc updated @josegar74 geonetwork/doc#234
Fix client IP address which was the proxy IP in Spring API call (was fine in Jeeves services) -
x-forwarded-forheader takes priority in all places now. Issue only happens when using HTTP reverse proxy (not AJP https://stackoverflow.com/questions/1180974/proxypass-proxyreverse-vs-ajp)If no Intranet configuration,
do not show the intranet group