-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmis performance enhancements #6893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As CMIS calls are slow - reduce cmis calls when inserting and updating properties during adding and updating resources. - Increase MaxItemsPerPage to 1000 to increase performance when there are over 100 attachments. - Fix bug with setting IncludeRelationships to none - Calculate default validation Status once and move to configuration. - Fixed bug where primary properties were not being copied during resource copy. - Other minor fixes.
josegar74
reviewed
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested the code, but changes look good, please check the suggestions.
core/src/main/java/org/fao/geonet/api/records/attachments/CMISStore.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/fao/geonet/resources/CMISConfiguration.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/fao/geonet/api/records/attachments/CMISStore.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/fao/geonet/resources/CMISConfiguration.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/fao/geonet/api/records/attachments/CMISStore.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Jose García <[email protected]>
…Store.java Co-authored-by: Jose García <[email protected]>
…Store.java Co-authored-by: Jose García <[email protected]>
Also updated some formatting.
josegar74
approved these changes
Mar 13, 2023
ianwallen
added a commit
that referenced
this pull request
Mar 14, 2023
* Cmis performance enhancements - As CMIS calls are slow - reduce cmis calls when inserting and updating properties during adding and updating resources. - Increase MaxItemsPerPage to 1000 to increase performance when there are over 100 attachments. - Fix bug with setting IncludeRelationships to none - Calculate default validation Status once and move to configuration. - Fixed bug where primary properties were not being copied during resource copy. - Other minor fixes. * Update core/src/main/java/org/fao/geonet/resources/CMISConfiguration.java Co-authored-by: Jose García <[email protected]> * Update core/src/main/java/org/fao/geonet/api/records/attachments/CMISStore.java Co-authored-by: Jose García <[email protected]> * Update core/src/main/java/org/fao/geonet/api/records/attachments/CMISStore.java Co-authored-by: Jose García <[email protected]> * Applied some constants based on code review Also updated some formatting. --------- Co-authored-by: Jose García <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cmis performance enhancements