PB-227: Helptext translations #76
Conversation
LukasJoss
force-pushed
the
feat-PB-227_helptext_translations
branch
2 times, most recently
from
aa5abb7 to
1304b40
Compare
|
the docker image has been changed and no longer contains the babs2 images see https://github.com/geoadmin/infra-kubernetes/commit/df73499cb5235fd65b12ae53c918c5212a5a10bf |
LukasJoss
force-pushed
the
feat-PB-227_helptext_translations
branch
from
80b262c to
aaa4528
Compare
LukasJoss
force-pushed
the
feat-PB-227_helptext_translations
branch
from
1082664 to
98eeefd
Compare
LukasJoss
force-pushed
the
feat-PB-227_helptext_translations
branch
4 times, most recently
from
b9d657d to
475bf57
Compare
LukasJoss
force-pushed
the
feat-PB-227_helptext_translations
branch
from
475bf57 to
363ded7
Compare
app/helpers/check_functions.py
Outdated
|
|
||
| Args: | ||
| icon_set: (IconSet) the icon set in which belongs the icon we want | ||
| icon_name: (str) the name of the icon |
There was a problem hiding this comment.
Currently only icon_set is an argument
There was a problem hiding this comment.
tbd @pakb @LukasJoss : Do we want to check the existence of keys in the dict for all languages here, or in the front-end?
There was a problem hiding this comment.
Probably front-end could handle the case when a certain language is missing in the returned dict, by simply skipping the mouseover text in that case
There was a problem hiding this comment.
We would probably need to define first which languages are required in the first place, but handling it on the front-end is probably fine
| @@ -0,0 +1,582 @@ | |||
| { | |||
| "001-I-Danneggiamento": { | |||
| "de": "Besch\u00e4digung", | |||
There was a problem hiding this comment.
is the encoding correct? Will this be correctly handled by the front-end?
| json_dic[string_id] = icon_dic | ||
|
|
||
| with open( | ||
| destination + '-' + filename[-1] + '-dictionary.json', "w", encoding='utf-8' |
app/helpers/description.py
Outdated
| def get_icon_description(icon_name='', icon_set=''): | ||
| ''' | ||
| Return json containing the description in all available languages for the specified icon of the | ||
| provided icon set |
There was a problem hiding this comment.
of the provided icon, not icon set
app/helpers/description.py
Outdated
|
|
||
| def find_descripton_file(icon_set): | ||
| ''' | ||
| Return file path of description file if it exists |
There was a problem hiding this comment.
please add or False in case it doen't
LukasJoss
force-pushed
the
feat-PB-227_helptext_translations
branch
from
1acf2ae to
899ef84
Compare
LukasJoss
force-pushed
the
feat-PB-227_helptext_translations
branch
from
899ef84 to
e1dfd45
Compare
No description provided.