Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIINF_SB-2163: Fixed CI github branch resolution #53

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Jan 31, 2022

Depending on the context the github branch resolution was wrong, for
example the github branch was resolved to another dependabot PR branch
due to the sed -n 2p which takes the second line of the git branch -a command.

Newly Codebuild provide a variable to know the base branch of a PR.

@github-actions github-actions bot added the bug label Jan 31, 2022
Depending on the context the github branch resolution was wrong, for
example the github branch was resolved to another dependabot PR branch
due to the `sed -n 2p` which takes the second line of the `git branch -a` command.

Newly Codebuild provide a variable to know the base branch of a PR.
@ltshb ltshb requested a review from pakb January 31, 2022 09:59
@ltshb
Copy link
Contributor Author

ltshb commented Jan 31, 2022

I created a jira ticket to do other repos: https://jira.swisstopo.ch/browse/BGDIINF_SB-2163

@ltshb ltshb changed the title Fixed CI github branch resolution BGDIINF_SB-2163: Fixed CI github branch resolution Jan 31, 2022
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, and good fix! Nice that CodeBuild gives us that now (was a pain in the ass to process manually)

@ltshb ltshb merged commit f12c554 into develop Jan 31, 2022
@ltshb ltshb deleted the bug-ci-gitbranch branch January 31, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants