BGDIINF_SB-2136: Added icon anchor #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This service is quite fast and doesn't make sense to have a 60s timeout, every request should be done without a few hundred milliseconds.
When using a valid scale not part of 1x, 0.5x or 2x, the service silently used scale 1x. Also when entering an invalid color value type, e.g. `@1x-0,0,a.pgn`, the service returned 404 instead of 400. Now we can use any valid scale and not only 1x, 0.5x and 2x. Also the parsing of the route don't uses converter anymore which improved the parsing and allow to use correct error message in case of invalid scale or invalid color.
This is then easier for human to read the output and debug it.
The marker icons have different anchor offset as the others, therefor the service is now returning for each icon which anchor it needs to use (default anchor is the center of the icon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The marker icons have different anchor offset as the others, therefore the service is now returning for each icon which anchor it needs to use (default anchor is the center of the icon).
Also update docu, added license, updated formatting, updated to python 3.9, improved route parsing, support for any scale and return proper 404 instead of 400 for icon not found.