[Feature] Update getblock verbosity semantics #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zquestz
changed the title
zquestz
changed the title
zquestz
force-pushed
the
getblockverbocity
branch
from
6c2ce35 to
1611080
Compare
|
Yay, I am glad to help! btw what linter do you use? I am about the second commit. I use some but it seems I miss something. |
|
Yeah in Go 1.11 they changed the semantics of gofmt -s ... so the output is slightly different than old versions. To get around it an extra line break makes it compatible with older versions of Go when we run the tests on travis. |
|
TIL, cool. Thanks. |
cpacia
approved these changes
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
btcsuite/btcd#1232
Thansks @reinerRubin