Convert unit tests into subtest and to be table-driven #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR addressing refactoring tests from #284. This addresses the following tests:
I converted all except
TestArray_IsEqual
to table driven style. I only splitTestArray_IsEqual/types
into subtests to address the multiple variable issue.Also, as noted in the issue, I ended up merging
TestNumber_EqualNaN
intoTestNumber_IsEqual
(and alsoTestNumber_InDelta
since half of the test related to InDelta/NotInDelta tests for NaN values). I ended up converting those tests to table-driven format as well.This is ready for review.