chore(gatsby): Fix index.d.ts file #33805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
topic: TypeScript
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
vladar
reviewed
Nov 2, 2021
vladar
approved these changes
Nov 2, 2021
5 tasks
LekoArts
added a commit
that referenced
this pull request
Nov 2, 2021
(cherry picked from commit 6c5de79)
LekoArts
added a commit
that referenced
this pull request
Nov 2, 2021
Co-authored-by: Lennart <[email protected]>
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We sadly can't really catch those things in CI at the moment as we have to use
skipLibCheckforgatsbyas our webpack types are messed up (we have webpack 4 types in lock file due to some outdated libs/type libs). You can see this by runningnpx tsc packages/gatsby/index.d.ts --noEmitin the repo rootSo for now we just manually fix this
Related Issues
Fixes #33747