Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add trainling slashes to doc-links.yaml #22933

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Apr 8, 2020

Description

changes:

  • unify all links and add trailing slash

related issues

@muescha muescha requested a review from a team as a code owner April 8, 2020 14:55
@muescha muescha changed the title add slash fix(docs): add trainling slashes to doc-links.yaml Apr 8, 2020
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this! For future reference, this and #22936 could probably have been a single PR. They're pretty closely related (and were introduced in the same PR).

@AishaBlake AishaBlake merged commit 8945b7a into gatsbyjs:master Apr 8, 2020
@muescha muescha deleted the muescha/fix/add-slash-in-toc branch April 13, 2020 17:50
@muescha
Copy link
Contributor Author

muescha commented Apr 13, 2020

@AishaBlake

in #22205 (comment) i got the advice that i should split it into smaller packages to make PR easy to check

open tightly-scoped PRs for each chunk of work, such as a section of the tutorial, to make it easier for us to review and test

and i agree it is more easy to check the small scoped chunks instead of a big one - thats why i opened it in separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants