Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): Migrate gatsbygram's createPages hook to async/await #15608

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

browniebroke
Copy link
Contributor

Description

While updating the docs, I stumbled upon a blog post for a case study about gatsbygram, which is one of the examples in the repo. This is a separate change to update the example to match with the docs.

Related Issues

Related to #11548 & #15577

@browniebroke browniebroke marked this pull request as ready for review July 10, 2019 18:29
@browniebroke browniebroke requested a review from a team as a code owner July 10, 2019 18:29
@browniebroke browniebroke force-pushed the gatsbygram-async-await branch from 8586d93 to 7b23a20 Compare July 17, 2019 09:07
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and addresses the same case outlined in issue #11548, LGTM!

Pulled down the changes just to make sure things run and since #15799 removed e2e tests for gatsbygram I think this wouldn't have caused any problems anyway.

@gillkyle gillkyle added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 17, 2019
@gillkyle gillkyle merged commit 54abc5f into gatsbyjs:master Jul 17, 2019
@gillkyle
Copy link
Contributor

Thanks @browniebroke! Appreciate the other PRs you opened as well.

@browniebroke browniebroke deleted the gatsbygram-async-await branch July 17, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants