fix(gatsby-transformer-documentationjs): handle free floating jsdocs #13058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
commented
Apr 3, 2019
packages/gatsby-transformer-documentationjs/src/__tests__/gatsby-node.js
Outdated
Show resolved
Hide resolved
stefanprobst
approved these changes
Apr 4, 2019
|
Confirmed that www builds with Loki with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not great fix, but it is fix for issue described in #13052 . This is happening because
documentionpackage creates 2 jsdocs for same object. I'm not sure if "free floating" jsdoc is valid or not (in scenarios other than defining type definition / callback), but because this is problematic quick fix is to not create multiple nodes with sameidFixes #13052