fix(www): a11y tweaks #11612
Merged
fix(www): a11y tweaks #11612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcysutton
approved these changes
Feb 7, 2019
|
@marcysutton is there any automated a11y checking we could do to catch regressions at PR time? Could be a nice CI check for www/. |
|
We could add axe-core/axe-webdriverjs to the test suite, it would be run as part of either unit or integration tests and could stop a build via CI. Here are some slides from a talk I did on it: https://marcysutton.github.io/a11y-and-ci/#/28 axe-puppeteer is out now too, in case you don't want to use Selenium Webdriver: https://github.com/dequelabs/axe-puppeteer |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* fix(www): make svg ids unique * fix(www): increase text color contrast of mobile nav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couple low-hanging fruit a11y tweaks: