-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mvdb/harvest command use argparse #527
Mvdb/harvest command use argparse #527
Conversation
class Command(BaseCommand): | ||
help = u'Run lettuce tests all along installed apps' | ||
args = '[PATH to feature file or folder]' | ||
requires_model_validation = requires_system_checks = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line gives an error on Django==1.8, so that's why I replaced it below with something smarter
class Command(BaseCommand): | ||
help = u'Run lettuce tests all along installed apps' | ||
args = '[PATH to feature file or folder]' | ||
requires_model_validation = requires_system_checks = False | ||
|
||
if DJANGO_VERSION < StrictVersion('1.9'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clause is unnecessary - we can just use requires_system_checks
with Django 1.8 as well as Django 1.9.
also, it works like a charm with Django 1.10.1 😄 |
@gabrielfalcao @nikolas do you think we could merge that? |
Hi @gabrielfalcao, manage.py harvest now working in django 10. Why does not it work ? |
Hi @m-vdb, manage.py harvest now working in django 10. Why does not it work ? |
@kairatomurbek2 it works well for us with Django 1.10.1. open an issue on this project with sufficient debugging information if you need help. |
@m-vdb Yes, I need help, I use Django 1.10.2 I have this error goes here |
Yes I need help, I have a Django 1.10.2 I run, but for some reason does not ./manage.py harvest acceptance_tests/features --settings=main.settings_test On Fri, Oct 21, 2016 at 12:27 AM, Maxime Vdb [email protected]
С уважением ! |
as you can see in the code of this repo, you won't find any reference to |
@m-vdb I have the latest version, I created a test project to test volatile, check please. https://github.com/kairatomurbek2/for_lettuce |
@m-vdb I'm still the same error comes |
Hi @gabrielfalcao,
Another PR related to Django 1.9: all commands now use
argparse
by default. So this PR switches the command fromoptparse
toargparse
. The bad thing about that is that this break compatibility with Django 1.7. The good thing is that your command will be instantly compatible with 1.10 (almost out ;)).LMK if you want to merge it or wait a little bit