Use same key convention for alternate route keys in dr/dynamic-router
#560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue fulcrologic#559 for more details on the bug. This commit opts for creating a utility function to create the keys, not because it isn't easily inlined, as was done before, but I thought it would codify and reduce the chances of a similar mismatch if this is needed again.
|
Great catch...I never create routers with that helper function. This explains my confusion...the macro is fine, It's the dyn one that is hosed. |
|
Thanks @awkay! I appreciate all that you do and for sharing all of this wonderful code and time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #559 for more details on the bug. This commit opts for
creating a utility function to create the keys, not because it isn't
easily inlined, as was done before, but I thought it would codify and
reduce the chances of a similar mismatch if this is needed again.