This repository was archived by the owner on Jun 4, 2019. It is now read-only.
Completed and tested challenge 1.3 on input. #20
Merged
+56
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everybody, meet Vlad! He is a friend of mine from college and loves writing Python :) I'll review this PR when I get home from work today 👍 |
|
LGTM. I'm going to go ahead and merge this, but in the future make sure to add the challenges.json file you generated and reference the curriculum outline issue #8 😄 Keep up the great work 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed challenge 1.3. Tried following chapter 4 as much as possible. I could not find a way to check if a function was called such as input. So I just check if Name and Age are strings since that is what input makes them. If someone knows of a better way to check please let me know and I will redo the tests! I am working on the rest of chapter 1 as well.