Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backups): setup backups for bench sites #972

Merged
merged 3 commits into from
Apr 17, 2020
+13 −28
Merged

fix(backups): setup backups for bench sites #972

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90f951c
fix(backups): setup backups for bench sites
gavindsouza Apr 15, 2020
f28c376
fix(backup): make auto backup logs verbose
gavindsouza Apr 16, 2020
6881c93
fix: bench path used for config
gavindsouza Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 13 additions & 28 deletions bench/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

# imports - third party imports
import click
from crontab import CronTab
import requests
from semantic_version import Version
from six import iteritems
Expand Down Expand Up @@ -361,42 +362,27 @@ def get_sites(bench_path='.'):
return sites


def get_bench_dir(bench_path='.'):
return os.path.abspath(bench_path)


def setup_backups(bench_path='.'):
from bench.config.common_site_config import get_config
logger.info('setting up backups')
bench_dir = get_bench_dir(bench_path=bench_path)

bench_dir = os.path.abspath(bench_path)
user = get_config(bench_path=bench_dir).get('frappe_user')
logfile = os.path.join(bench_dir, 'logs', 'backup.log')
bench.set_frappe_version(bench_path=bench_path)
system_crontab = CronTab(user=user)

if bench.FRAPPE_VERSION == 4:
backup_command = "cd {sites_dir} && {frappe} --backup all".format(frappe=get_frappe(bench_path=bench_path),)
else:
backup_command = "cd {bench_dir} && {bench} --site all backup".format(bench_dir=bench_dir, bench=sys.argv[0])

add_to_crontab('0 */6 * * * {backup_command} >> {logfile} 2>&1'.format(backup_command=backup_command,
logfile=os.path.join(get_bench_dir(bench_path=bench_path), 'logs', 'backup.log')))
backup_command = "cd {bench_dir} && {bench} --verbose --site all backup".format(bench_dir=bench_dir, bench=sys.argv[0])

job_command = "{backup_command} >> {logfile} 2>&1".format(backup_command=backup_command, logfile=logfile)

def add_to_crontab(line):
current_crontab = read_crontab()
line = str.encode(line)
if not line in current_crontab:
cmd = ["crontab"]
if platform.system() == 'FreeBSD':
cmd = ["crontab", "-"]
s = subprocess.Popen(cmd, stdin=subprocess.PIPE)
s.stdin.write(current_crontab)
s.stdin.write(line + b'\n')
s.stdin.close()


def read_crontab():
s = subprocess.Popen(["crontab", "-l"], stdin=subprocess.PIPE, stdout=subprocess.PIPE)
out = s.stdout.read()
s.stdout.close()
return out
if job_command not in str(system_crontab):
job = system_crontab.new(command=job_command, comment="bench auto backups set for every 6 hours")
job.hour.every(6)
system_crontab.write()


def setup_sudoers(user):
Expand Down Expand Up @@ -553,7 +539,6 @@ def restart_supervisor_processes(bench_path='.', web_workers=False):


def restart_systemd_processes(bench_path='.', web_workers=False):
from .config.common_site_config import get_config
bench_name = get_bench_name(bench_path)
exec_cmd('sudo systemctl stop -- $(systemctl show -p Requires {bench_name}.target | cut -d= -f2)'.format(bench_name=bench_name))
exec_cmd('sudo systemctl start -- $(systemctl show -p Requires {bench_name}.target | cut -d= -f2)'.format(bench_name=bench_name))
Expand Down