Windows: Improve CredWrite() error handling #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wondering if there is a way to use the .._BLOB_SIZE as run time constant instead of compile time? |
|
@guruz Interesting point. We could do the size checks only after we see an INVALID_PARAMETER error, and not do error catching ourselves upfront. I'll make adjustments. |
ckamm
force-pushed
the
credwrite-errors
branch
from
22236d6 to
f28490b
Compare
guruz
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
I think it's good, but a second pair of eyes would be nice too
@ogoffart @akallabeth
ogoffart
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #133