Adjust --detailed-resources to sierra-gas tracking #3051
+87
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2025
THenry14
requested review from
ddoktorski,
kkawula and
cptartur
and removed request for
a team
THenry14
force-pushed
the
szymczyk/sg-2-run-tests-with-cairo-steps-explicitly
branch
from
393a3c5 to
ad52dbe
Compare
THenry14
force-pushed
the
szymczyk/sg-3-detailed-resources
branch
2 times, most recently
from
f1224ef to
ae4aa88
Compare
cptartur
reviewed
Mar 10, 2025
| @@ -847,6 +847,33 @@ fn detailed_resources_flag() { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg_attr(not(feature = "scarb_since_2_10"), ignore)] | |||
There was a problem hiding this comment.
I think this PR should set a CI job as well to run this
There was a problem hiding this comment.
This is done in #3055 , but if you really want it here I can backport 👍
ksew1
reviewed
Mar 10, 2025
THenry14
force-pushed
the
szymczyk/sg-2-run-tests-with-cairo-steps-explicitly
branch
from
ad52dbe to
0d2a153
Compare
THenry14
force-pushed
the
szymczyk/sg-3-detailed-resources
branch
from
ae4aa88 to
90413b2
Compare
ksew1
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2977
This PR stack aims to add support for new resource tracking (sierra-gas) and new gas representation (GasVector triplet instead of single l1 gas value).
-- (#3049) Add sierra gas tracking
-- (#3050) Run already existing tests with CairoSteps set explicitly
-- (This PR) Add support for sierra gas in
--detailed-resources-- (#3052) Add support for sierra gas in
--save-trace-data-- (#3053) Add sierra version assertion
-- (#3054) Introduce new gas representation
-- (#3055) Add gas tests for sierra-gas tracking
-- (#3056) Update docs with sierra-gas related changes