Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove account type emum redundancy #2946

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Remove account type emum redundancy #2946

wants to merge 33 commits into from
+39 −57

Conversation

RichoKD
Copy link
Contributor

@RichoKD RichoKD commented Feb 16, 2025 •
edited
Loading

Closes #2571

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

kkawula
kkawula reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, some checks are still failing. Remember to remove comments and todos from the code. You can also run cargo fmt to format code and cargo lint to validate

@RichoKD RichoKD marked this pull request as ready for review February 17, 2025 18:24
@RichoKD RichoKD requested a review from a team as a code owner February 17, 2025 18:24
franciszekjob
franciszekjob requested changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RichoKD, we should remove one of the enums instead of renaming it.

@RichoKD
Copy link
Contributor Author

RichoKD commented Feb 18, 2025

Hi @RichoKD, we should remove of of the enums instead of renaming it.

OK

@RichoKD
Copy link
Contributor Author

RichoKD commented Mar 4, 2025

Hi @RichoKD, we should remove one of the enums instead of renaming it.

It's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner automatically assigned from foundry-rs/starknet-foundry

@kkawula kkawula Awaiting requested review from kkawula

@franciszekjob franciszekjob Awaiting requested review from franciszekjob

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove redundancy in AccountType enums
3 participants
@RichoKD @franciszekjob @kkawula