Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundancy in AccountType enums #2571

Open
franciszekjob opened this issue Oct 8, 2024 · 3 comments · May be fixed by #2946
Open

Remove redundancy in AccountType enums #2571

franciszekjob opened this issue Oct 8, 2024 · 3 comments · May be fixed by #2946
Assignees
@RichoKD
Labels
help wanted OnlyDust Assigned refactor sncast
Milestone
Cast refactor

Comments

@franciszekjob
Copy link
Collaborator

Which components does the task require to be changed? (think hard pls)

sncast

Description

There are currently two similar AccountType enums. We should consider refactoring to keep only one to avoid redundancy.

Refs:

starknet-foundry/crates/sncast/src/lib.rs

Line 45 in 526e415

pub enum AccountType {

starknet-foundry/crates/sncast/src/starknet_commands/account/mod.rs

Line 42 in 526e415

pub enum AccountType {

@franciszekjob franciszekjob mentioned this issue Oct 8, 2024
Merged
5 tasks
@cptartur cptartur removed the new label Oct 17, 2024
@cptartur cptartur moved this from New to Triage in Starknet foundry Oct 17, 2024
@cptartur cptartur added this to the Cast refactor milestone Oct 23, 2024
@RichoKD
Copy link
Contributor

RichoKD commented Feb 3, 2025

Hi @cptartur, can I try this?
I plan to remove the AccountType in /crates/sncast/src/starknet_commands/account/mod.rs before tracking all references to it and replacing them after which I'll run test to confirm nothing is broken.

@cptartur
Copy link
Member

@RichoKD assigned

@RichoKD
Copy link
Contributor

RichoKD commented Feb 11, 2025

I'm on it

@RichoKD RichoKD mentioned this issue Feb 13, 2025
Closed
5 tasks
@kkawula kkawula moved this from Triage to In Progress in Starknet foundry Feb 13, 2025
@RichoKD RichoKD linked a pull request Feb 16, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichoKD RichoKD

Labels
help wanted OnlyDust Assigned refactor sncast
Projects
Starknet foundry
Status: In Progress
Milestone
Cast refactor
3 participants
@RichoKD @cptartur @franciszekjob