Fix hamburger icon #9454
Merged
Fix hamburger icon #9454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoden
reviewed
Dec 5, 2016
|
|
||
| content: ''; | ||
|
|
||
| @for $i from 2 through $bars { | ||
| $offset: ($weight + $spacing) * ($i - 1); | ||
| $shadow: append($shadow, 0 $offset 0 $color, comma); | ||
| } | ||
|
|
||
| box-shadow: $shadow; |
There was a problem hiding this comment.
I think it would be more clear to keep box-shadow in the property list background, and move the logic stuff above, line 75 or 86.
There was a problem hiding this comment.
For organizing purposes, I've added a new commit that moves up the related logic code to be at the top of Hamburg mixin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that has been noticed in v6.3.0-rc1. The bug disappears some Hamburger icon's bars, and the full bars only appear on hover mode