Fix #8325 - expanded menu #9442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ncoden
force-pushed
the
fix/menu-expanded
branch
from
94da9ca to
1c70a57
Compare
Fix foundation#8325. See also: foundation#8779. Thanks to @natewiebe13. `.expanded` is a modifier for a horizontal menu, and should not be applied on a vertical one. Changes: - Move the `.expanded` modifier after `.horizontal` and before `.vertical`. - Add the `.expanded` modifiers for each breakpoint with the corresponding prefixes. Other changes: - Use `-zf-each-breakpoint` to generate responsive modifiers. Note: The `.expanded` modifier should be applied only when the menu is horizontal. For example, on a menu which is made horizontal on the medium breakpoint, `.medium-expanded` should be used : `.menu.vertical.medium-horizontal.medium-expanded`.
ncoden
force-pushed
the
fix/menu-expanded
branch
3 times, most recently
from
bec45cf to
2c6b800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8325 -
.expandedis a modifier for a horizontal menu, and should not be applied on a vertical menu.Changes:
.expandedmodifier after.horizontaland before.vertical..expandedmodifiers for each breakpoint with the corresponding prefixes.Other changes:
-zf-each-breakpointto generate responsive modifiers. (require Fix -zf-each-breakpoint without small #9441)Note: The
.expandedmodifier should be applied only when the menu is horizontal. For example, on a menu which is made horizontal on the medium breakpoint,.medium-expandedshould be used :.menu.vertical.medium-horizontal.medium-expanded.See also: #8779. (Thanks to @natewiebe13).
Working demo: https://codepen.io/ncoden/pen/dOdjaO