Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict selector to menus and menu-items #9110

Merged
merged 1 commit into from
Oct 7, 2016
Merged

restrict selector to menus and menu-items #9110

merged 1 commit into from
Oct 7, 2016

Conversation

pine3ree
Copy link
Contributor

@pine3ree pine3ree commented Aug 14, 2016

this allows to have elements inside li with the "is-active" class not removed by the Burn method

@pine3ree
Copy link
Contributor Author

closing and reopening to skip travis build failure (Failed at the [email protected] install script 'node install.js'.)

@pine3ree pine3ree closed this Aug 14, 2016
@pine3ree pine3ree reopened this Aug 14, 2016
@pine3ree
Copy link
Contributor Author

retrying travis build

@pine3ree pine3ree closed this Aug 15, 2016
@pine3ree pine3ree reopened this Aug 15, 2016
@rspraymond
Copy link
Contributor

@pine3ree Anything special you did to get the build to complete? I'm having the same issue with my pull request. #9111

@pine3ree
Copy link
Contributor Author

pine3ree commented Aug 15, 2016

@rspraymond
Hello. There are some issues with travis build during node modules installation. I closed and reopened ky PR to trigger another travis test.

kind regards

update:
i just checked the travis failure in your pr, it's the same issue I had (npm install failure).

@kball
Copy link
Contributor

kball commented Oct 7, 2016

This seems good to me.

@kball kball merged commit 379cf80 into foundation:develop Oct 7, 2016
@pine3ree pine3ree deleted the patch-11 branch October 7, 2016 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants