Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings for the hover color for thead and tfoot #9048

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Add settings for the hover color for thead and tfoot #9048

merged 1 commit into from
Oct 6, 2016

Conversation

natewiebe13
Copy link
Contributor

This fixes a bug where hovering the header or footer with a modified background color, would change the background color to be the same as the body.

@natewiebe13 natewiebe13 reopened this Jul 26, 2016
@natewiebe13
Copy link
Contributor Author

Reopened to rebuild.

@andycochran
Copy link
Contributor

Should this maybe use the smart-scale function instead of darken? In some cases, lighten might be preferable.

@natewiebe13
Copy link
Contributor Author

I used darken to be consistent with the existing functionality. If requested, I can change it to use smart-scale.

@andycochran
Copy link
Contributor

Ooh, my mistake; $table-row-hover does default to darken. Apologies. This looks good to me. 👍

@kball kball merged commit b1176ac into foundation:develop Oct 6, 2016
@natewiebe13 natewiebe13 deleted the table-hover branch December 20, 2016 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feedback wanted scss
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natewiebe13 @andycochran @kball